• V0ldek@awful.systems
    link
    fedilink
    English
    arrow-up
    33
    ·
    6 months ago

    You also definitely shouldn’t be using String non-monotonic UUIDs for primary keys in a database, like, literally ever, but what the fuck do I know, I just do databases for a living, I’m not the all-knowing GPT code wizard.

    • flere-imsaho@awful.systems
      link
      fedilink
      English
      arrow-up
      15
      ·
      6 months ago

      i’m not doing databases for living but the idea of stringifying a perfectly cromulent unique number in order to store it in the database comes as slightly weird to me.

    • deborah@awful.systems
      link
      fedilink
      English
      arrow-up
      12
      ·
      6 months ago

      If you’re using a new-to-you ORM, and you don’t ever check the docs to see the basic primary key syntax… it’s SQLAchemy, it’s well documented and there’s tons of prior art.

      Also I don’t understand their business case but if a user has a primary key, a unique user ID, and a unique customer ID, then all three of those uniquely identify the customer. (Weird, but there are some plausible explanations.) But then why would you need both the user ID and the customer ID in the subscription table is this some stripe thing I don’t understand or are they just bad at this?

    • Imacat@lemmy.dbzer0.com
      link
      fedilink
      English
      arrow-up
      4
      arrow-down
      7
      ·
      6 months ago

      UUIDs make great primary keys in some applications. If you generated 100 trillion UUID4s, there’s about a 1 in a billion chance of finding a duplicate. Thats usually good enough for my databases.

      The issue here was that they used a single UUID instead of generating a new one for each record.

      • deborah@awful.systems
        link
        fedilink
        English
        arrow-up
        19
        ·
        6 months ago

        There are countless issues here. They didn’t do exception handling, they used a string to store their UUIDs (even if this was a DB constraint, you use sqlalchemy.Uuid and let the ORM and DB handle the translation), and as the person you’re replying to stressed, they’re using non-monotonic UUIDs. Also if you have a unique user_id and you’re never exposing your primary keys, you don’t need to get fancy, just let the ORM handle it with auto-incrementing, for most use cases. And so many other tragic things about this one tiny blog post.

        tl;dr if you’re going to copy code you don’t understand, copy it from the docs, not from everything in the kitchen thrown into a blender.

        • Imacat@lemmy.dbzer0.com
          link
          fedilink
          English
          arrow-up
          5
          arrow-down
          2
          ·
          6 months ago

          I was reading it as an endorsement for autoincrementing int primary keys and a condemnation of uuids in general which is a genuine stance I’ve known people to take. Is that not it?

          • froztbyte@awful.systems
            link
            fedilink
            English
            arrow-up
            8
            ·
            6 months ago

            indeed, that is not it

            hint: don’t try to “read in” any extra meanings. just read the actual statement that was posted.

              • Imacat@lemmy.dbzer0.com
                link
                fedilink
                English
                arrow-up
                3
                arrow-down
                2
                ·
                6 months ago

                Would they not have monotonic uuids after altering the code in the article to use a function or lambda as they suggested?

                • ebu@awful.systems
                  link
                  fedilink
                  English
                  arrow-up
                  6
                  arrow-down
                  1
                  ·
                  edit-2
                  6 months ago

                  you might know what “monotonic” means if you had googled it, which would also give you the answer to your question

                  edit: this was far too harsh of a reply in retrospect, apologies. the question is answered below, but i’ll echo it: a “monotonic UUID” is one that numerically increases as new UUIDs are generated. this has an advantage when writing new UUIDs to indexed database columns, since most database index structures are more efficient when inserting at the end than at a random point (non-monotonic UUID’s).

          • JackbyDev@programming.dev
            link
            fedilink
            English
            arrow-up
            4
            arrow-down
            3
            ·
            edit-2
            6 months ago

            Everything after this is so pointlessly condescending and confusing. Even if someone knows what monotonic ids are it doesn’t automatically mean they’re going to have any clue about what that means with regards to index performance. In the spirit of not being an asshole, I’ll write it out here based on my research since everyone else just seems interested in putting others down rather than being helpful.

            • “Monotonic” implies something that is always increasing (or decreasing). You’ll never get a result that’s lower than one you’ve gotten before (or higher if you’re dealing with monotonically decreasing stuff).
            • Random UUIDs are not monotonic because they’re random.
            • Even time based UUIDs are not monotonic because of the format. Rather than being store high, medium, low, they’re stored low, medium, high. Think of it like storing numbers like “1 20 300” for 321. 322 would be “2 20 300”. To make it worse, the end of them is “random” (a MAC address). So, not monotonic at all because MAC addresses can change. (See here for proposed new formats, where they mention this as a problem https://www.ietf.org/archive/id/draft-peabody-dispatch-new-uuid-format-04.html)
            • Monotonic primary keys are useful because they’re more easily inserted into an index because you’re always inserting into one specific part of the index rather.
            • ebu@awful.systems
              link
              fedilink
              English
              arrow-up
              10
              ·
              edit-2
              6 months ago

              putting my 2¢ forward: this is a forum for making fun of overconfident techbros. i work in tech, and it is maddening to watch a massively overvalued industry buy into yet another hype bubble, kept inflated by seemingly endless amounts of money from investors and VCs. and as a result it’s rather cathartic to watch (and sneer at) said industry’s golden goose shit itself to death over and over again due to entirely foreseeable consequences of the technology they’re blindly putting billions of dollars into. this isn’t r/programming, this is Mystery Science Theater 3000.

              i do not care if someone does or does not understand the nuances of database administration, schema design, indexing and performance, and different candidates for the types of primary keys. hell, i barely know just enough SQL to shoot myself in the foot, which is why i don’t try to write my own databases, in the hypothetical situation where i try to engineer a startup that “extracts web data at scale with multimodal codegen”, whatever that means.

              if someone doesn’t understand, and they come in expressing confusion or asking for clarification? that’s perfectly fine – hell, if anything, i’d welcome bringing people up to speed so they can join in the laughter.

              but do not come in here clueless and confidently (in)correct the people doing the sneering and expect to walk away without a couple rotten tomatoes chucked at you. if you want to do that, reddit and hacker news are thataway.

            • slopjockey@awful.systems
              link
              fedilink
              English
              arrow-up
              7
              ·
              6 months ago

              Yeah, I’m all for dunking on promplets, but just being wrong about best practice isn’t a big deal. The reaction here is excessively harsh.

              • self@awful.systems
                link
                fedilink
                English
                arrow-up
                10
                ·
                6 months ago

                agreed. we’ve veered a bit too close to slashdot’s tone on this one.

                with that said, I’m also acutely aware of the tactics that programming.dev reply guys use to generate these kinds of responses. to our guests: it’s best to take your questions about database best practices literally anywhere else but here.

                • froztbyte@awful.systems
                  link
                  fedilink
                  English
                  arrow-up
                  6
                  ·
                  6 months ago

                  with that said, I’m also acutely aware of the tactics that programming.dev reply guys

                  I wasn’t actually aware of this, and will be taking note of it in future. for my part I tried to make my reply “uhh go look at $x and learn” post without, y’know, overtly making things into a not-meant-for-here debate setup, but that didn’t seem to have worked out entirely well :)

              • V0ldek@awful.systems
                link
                fedilink
                English
                arrow-up
                9
                ·
                6 months ago

                Just to be clear, if a person is wrong about best practices then it’s not a big deal.

                In context of spicy autocomplete as coding assistance, it better output immaculate, robust code every fucking time or we should be clowning on it with zero remorse.

                • slopjockey@awful.systems
                  link
                  fedilink
                  English
                  arrow-up
                  6
                  ·
                  6 months ago

                  Wait a second…to err is to be human. Programmers err sometimes. ChatGPT shits itself all the time…😟. Yud et al. were right

      • Hexarei@programming.dev
        link
        fedilink
        English
        arrow-up
        4
        arrow-down
        5
        ·
        edit-2
        6 months ago

        They’re good for large, distributed applications for sure. Better than incrementing integers for those kinds of applications at the very least.

        For the folks in the article though? lol they were making no good decisions

        • deborah@awful.systems
          link
          fedilink
          English
          arrow-up
          14
          ·
          edit-2
          6 months ago

          when you do not yet have (1) customers, (B) unit tests, (ג) developers who can write their own code, or (IV) exception handling, the term-of-art that comes to mind for doing anything besides auto-incrementing primary keys is YAGNI. (Especially because nobody who is making thoughtful, careful database tuning decisions is using chat-gippity to convert their models. And more to the point, they aren’t using SQLAlchemy of all things to make large, distributed applications that need UUID primary keys.)

          • Hexarei@programming.dev
            link
            fedilink
            English
            arrow-up
            3
            arrow-down
            3
            ·
            edit-2
            6 months ago

            Oh for sure, the article folks are inept and absolutely not the people I was talking about. I’m just talking about stuff more like Discord or Steam that are huge distributed systems that don’t use centralized databases.

            Edit: that don’t use centralized databases. I blame the ADHD.

            Edit 2: I am agreeing with this person

            • ebu@awful.systems
              link
              fedilink
              English
              arrow-up
              9
              ·
              6 months ago

              I’m just talking about stuff more like Discord or Steam that are huge distributed systems that don’t use databases.

              huh???

              • Hexarei@programming.dev
                link
                fedilink
                English
                arrow-up
                8
                ·
                6 months ago

                Whoops, I flubbed that message hard and didn’t catch it at the time: Meant to say “don’t use centralized databases.” They definitely use databases lmao. No idea how I screwed that message up so hard. I blame ADHD for not proofreading.

                Just so we’re on the same page, let me be more specific. I’m saying the individuals in the article were making terrible decisions. Lots of them.

                I am also saying that UUIDs are good primary keys for very specific purposes: Large, distributed systems that handle large amounts of small data, powered by databases like Cassandra that are designed to handle millions of record insertions per hour across several hundred nodes, to the point where inserts are very likely to happen at the exact same time on two different replicas of the same schema.

                Hope that makes more sense than my previous flub. lol

                • ebu@awful.systems
                  link
                  fedilink
                  English
                  arrow-up
                  5
                  ·
                  edit-2
                  6 months ago

                  okay that’s a little more sensible lol

                  i think the original comment that this thread is in reply to is avoiding non-monotonic UUIDs. i don’t think anyone is contesting that autoincrementing ints create headaches when trying to distribute the database

              • froztbyte@awful.systems
                link
                fedilink
                English
                arrow-up
                5
                ·
                6 months ago

                See, reason being is they use aethernet - that’s the only way you get to get scale it like this. Without that, communication and storage would just be impossible!

                • Hexarei@programming.dev
                  link
                  fedilink
                  English
                  arrow-up
                  8
                  ·
                  6 months ago

                  I accidentally a word in the original comment, it was supposed to say they don’t use *centralized databases. Instead it said I’m a moron lmao.

  • Architeuthis@awful.systems
    link
    fedilink
    English
    arrow-up
    26
    ·
    edit-2
    6 months ago

    Honestly, the evident plethora of poor programming practices is the least notable thing about all this; using roided autocomplete to cut corners was never going to be a well calculated decision, it’s always the cherry on top of a shit-cake.

    • ebu@awful.systems
      link
      fedilink
      English
      arrow-up
      22
      ·
      6 months ago

      the upside: we can now watch “disruptive startups” go through the aquire funding -> slapdash development -> catastrophic failure -> postmortem cycle at breakneck speeds

    • swlabr@awful.systems
      link
      fedilink
      English
      arrow-up
      12
      ·
      6 months ago

      roided autocomplete

      My autocomplete:

      • written in an hour on a whiteboard for a job interview
      • uses only the finest words, hand-selected by unix
      • speed and size efficient

      Roided autocomplete:

      • years of development, billions of dollars of investment
      • hallucinates constantly
      • projected to use all computing capacity at current rates
  • gerikson@awful.systems
    link
    fedilink
    English
    arrow-up
    22
    ·
    edit-2
    6 months ago

    The original post was removed, hence the archive link.

    HN figures the real issue was the lack of testing/monitoring, not specifically the use of ChatGPT. But the kind of person who’s ok with letting spicy autocomplete write their customer acquisition code is probably not the kind of person knowing how to test and monitor.

    https://news.ycombinator.com/item?id=40627558

    • fubarx@lemmy.ml
      link
      fedilink
      English
      arrow-up
      16
      ·
      6 months ago

      I actually tried letting ChatGPT-4o write some tests the other day.

      Easily 50% of the tests were wrong. They ignored DB uniqueness constrains or even datatypes. In a few cases, they just hallucinated field names that didn’t exist.

      I ended up spending just as much time cleaning up the cruft as writing them. I could easily see someone just starting out letting the code go through.

    • Sailor Sega Saturn@awful.systems
      link
      fedilink
      English
      arrow-up
      14
      ·
      6 months ago

      Commit messages are overrated.

      Now that’s the kind of bad hot take I read awful.systems for! Let’s all call ourselves “engineers” but write no documents but emoji laden jokes, and produce no work except for the copy-pasted excreta from a chatbot!

  • froztbyte@awful.systems
    link
    fedilink
    English
    arrow-up
    16
    ·
    edit-2
    6 months ago

    friend of mine happened to dm me this the other day, and here are my reactions from chat, verbatim (albeit timestamps removed)

    fucking sfba method, man
    so many things in that post, man, god
    linear extrapolation for “lost sales”, doing the double presumption of both constant uptake and that everyone would definitely have been a customer
    “whatever you’re thinking, double it” bayfucker advice
    and just …. everything
    fucking hell
    

    and the code. fuck me the fucking code. it’s always “nice” to see just how very very clever all the yc fuckers are. but christ does it give me feelings.

    but they gotta go fast! if they’re barely approaching redshift, are they even agile?!

    • deborah@awful.systems
      link
      fedilink
      English
      arrow-up
      14
      ·
      6 months ago

      It’s okay to copy/paste your basic model structure for SQLAlchemy classes, but copy and paste from the SQLAlchemy docs. Sweet suffering stack overflow, did nobody even look at the docs ever, or did they only trust ChatGPT? SQLAlchemy‘s simple for basic use cases.

      Also here is such a nutshell of everything wrong with YC: jackhole prompt fondlers with no tests, no paying customers, who turn on the most important new feature in prod at the end of the day (jesus wept), and yet with all that clown show,

      We had eight ECS tasks on AWS, all running five instances of our backend (overkill, yes we know, but to be fair we had AWS credits).

      What the actual fuck.

      • froztbyte@awful.systems
        link
        fedilink
        English
        arrow-up
        11
        ·
        6 months ago

        Oh yeah I entirely agree about copying - hell, lord knows how much interlang tools suck, I entirely get copycloning some defs best-match

        But yeah indeed they super fucked up :D

        With a nice cushy bit of “free” to make the problem go away. Whereas recently a fedi admin got their their instance turboscraped and were stressing about a sub-10k bill that would’ve probably killed their entirely service. My contempt for these bayfucker dickweeds knows no bound.

  • Soyweiser@awful.systems
    link
    fedilink
    English
    arrow-up
    14
    ·
    edit-2
    6 months ago

    How did they not find this while testing?

    e: Regardless, I don’t regret the experience.

    eurgh

    • Sailor Sega Saturn@awful.systems
      link
      fedilink
      English
      arrow-up
      20
      ·
      edit-2
      6 months ago

      Even with inadequate tests, inadequate monitoring, and an inadequate integration testing environment; how did it not go like this:

      “Hmm the web server appears to be working, but maybe the database is making an oopsie we did just do that whole stupid db migration without a gradual ramp up”

      “Oh hey here’s an idea, why don’t we make sure error messages from the database are logged maybe it’s silently crying out in pain right now :D”