• Sibbo@sopuli.xyz
    link
    fedilink
    arrow-up
    105
    ·
    5 months ago

    The real joke here is that after causing millions of pointless refactorings and rewrites, now finally the source book is affected as well.

    • BatmanAoD@programming.dev
      link
      fedilink
      arrow-up
      29
      ·
      edit-2
      5 months ago

      Unlikely, unless his view has changed substantially in the last seven years: https://blog.cleancoder.com/uncle-bob/2017/01/11/TheDarkPath.html

      I think his views on how to achieve good quality software are nearly antithetical to the goals of Rust. As expressed in that blog post and in Clean Code, he thinks better discipline, particularly through writing lots and lots of explicit unit tests, is the only path to reliable software. Rust, on the other hand, is very much designed to make the compiler and other tooling bear as much of the burden of correctness as possible.

      (To be clear, I realize you’re kidding. But I do think it’s important to know just how at odds the TDD philosophy is from the “safe languages” philosophy.)

      • JackbyDev@programming.dev
        link
        fedilink
        English
        arrow-up
        11
        ·
        5 months ago

        Ahhhh, the ol’ “dynamic languages are better than static languages because I have tests that check for different types” argument.

      • nous@programming.dev
        link
        fedilink
        English
        arrow-up
        6
        ·
        edit-2
        5 months ago

        This is an absolute terrible post :/ I cannot believe he thinks that is a good argument at all. It basically boils down to:

        Here is a new feature modern languages are starting to adopt.

        You might thing that is a good thing. Lists various reasonable reasons it might be a good thing.

        The question is: Whose job is it to manage that risk? Is it the language’s job? Or is it the programmer’s job?

        And then moves on to the next thing in the same pattern. He lists loads of reasonable reasons you might want the feature gives no reasons you would not want it and but says everything in a way to lead you into thinking you are wrong to think you want these new features while his only true arguments are why you do want them…

        It makes no sense.

      • lad@programming.dev
        link
        fedilink
        English
        arrow-up
        5
        ·
        edit-2
        5 months ago

        rather strongly typed Java.

        [In Java] you can also violate many of the type rules whenever you want or need to

        Okay. Well maybe being able to not spell out types every single time would also count as not burdening the programmer ¯\_(ツ)_/¯

        I bought Clean Code when I started learning programming, some of it was useful, but now I understand that it was too opinionated for a beginner

        Edit: also

        Whose job is it to manage that risk? Is it the language’s job? Or is it the programmer’s job[?]

        It is language’s job to enforce risk management wherever possible, humans are demonstrated time and time again to be poor at risk management (same for the other questions like ‘whose job it is to check for nulls’

        Edit2:

        Defects are the fault of programmers. It is programmers who create defects

        … and that is why he proposes to not help programmers with language means. I never thought that views of how problems should be tackled might differ so much while having in mind the same reasons and goals.

        Albeit I do agree that one must write tests, even if language helps, not everything can reasonably be automatically checked

      • puchaczyk@lemmy.blahaj.zone
        link
        fedilink
        arrow-up
        5
        ·
        edit-2
        5 months ago

        To my knowledge, the Rust’s book actually encourages writing as many automated tests as you can, as the compiler can’t catch every type of bug in existance.

        • BatmanAoD@programming.dev
          link
          fedilink
          arrow-up
          2
          ·
          5 months ago

          Yes. True. But Uncle Bob literally complains about non-nullable types in the linked blog post.

          I’m not saying testing isn’t important. I’m saying that hand-written unit tests are not the end-all be-all of software quality, and that Uncle Bob explicitly believes they are.

      • petey@aussie.zone
        link
        fedilink
        arrow-up
        5
        ·
        5 months ago

        His take strangely acknowledges that defects are caused by programmers, yet doesn’t want to improve the tools we use to help us not make these mistakes. In summary, git gud.

        Experience has taught me that I’m awfully good at finding and firing foot guns, and when I use a language that has fewer foot guns along with good linting, I write reliable code because I tend to focus on what I want the code to do, not how to get there.

        Declarative functional programming suits me down to the ground. OOP has been friendly to me, mostly, but it also has been the hardest to understand when I come back to it. Experience has given me an almost irrational aversion to side effects, and my simple mind considers class members as side effects

      • anti-idpol action@programming.dev
        link
        fedilink
        arrow-up
        3
        ·
        5 months ago

        Funny how he is actually now a fan of Clojure yet the examples in his book are actually full of mutating data and side effects. And Rich Hickey also stressed that tests are no silver bullet.

    • addie@feddit.uk
      link
      fedilink
      arrow-up
      16
      arrow-down
      1
      ·
      5 months ago

      You can write an unmaintainable fucking mess in any language. Rust won’t save you from cryptic variable naming, copy-paste code, a complete absence of design patterns, dreadful algorithms, large classes of security issues, unfathomable UX, or a hundred other things. “Clean code” is (mostly) a separate issue from choice of language.

      Don’t get me wrong - I don’t like this book. It manages to be both long-winded and facile at the same time. A lot of people seem to read it and take the exact wrong lessons about maintainability from it. I think that it would mostly benefit from being written in pseudocode - concentrating on any particular language might distract from the message. But having a few examples of what a shitfest looks like in a few specific languages might help

        • addie@feddit.uk
          link
          fedilink
          arrow-up
          1
          ·
          4 months ago

          As an example of a language that many people are familiar with, which is likely to be in long-term use where maintainability is most important, and which can almost read like pseudocode anyway, sure - probably the best ‘real language’ choice.

    • popcar2@programming.dev
      link
      fedilink
      arrow-up
      20
      ·
      5 months ago

      inexperienced big brain developer see nested loop and often say “O(n^2)? Not on my watch!”

      complexity demon spirit smile

      This hits too close to home.

    • petey@aussie.zone
      link
      fedilink
      arrow-up
      8
      ·
      5 months ago

      I feel like this is a perfect encapsulation of how an experienced self-aware developer thinks. Experience really beats the hard stances out of you. I find myself saying “it depends” and “a bit of column A, bit of column B” often, like a cheap kids toy

  • xmunk@sh.itjust.works
    link
    fedilink
    arrow-up
    42
    ·
    5 months ago

    Honestly, a pretty fucking hilarious take. I wonder if he’s publishing a new book because the old dead tree format was boring and there’s some new crystal inscription system he read about on the forums.

  • Prunebutt@slrpnk.net
    link
    fedilink
    arrow-up
    29
    arrow-down
    3
    ·
    5 months ago

    I don’t really get the hate he gets in the other comments. Are you all joking, or can someone elaborate? I always liked what I’ve read/heard of Bob.

    • ByteOnBikes@slrpnk.net
      link
      fedilink
      arrow-up
      42
      arrow-down
      5
      ·
      edit-2
      5 months ago

      I’m not as much vitriol as others about Clean Code, but I will argue that engineers who preach the book as some sort of scripture are really obnoxious.

      I love the Single Responsibility Principle, in theory.

      What I don’t like is when devs try to refactor everything to that idea to achieve “Clean Code”. I’ve seen devs over-architect a solution, turning one function into many, because they don’t want to break that rule. Then point to this book as to WHY their code is now 20x longer than it needs to be.

      It also doesn’t help that every recommendation about good programming books include this.

      It’s like recommending a Fitness book from the 70s - information made sense at the time, but new research has made a lot of the advice questionable.

      My main issue is the whole “Uncle Bob” persona. Robert C Martin is sexist and a racist, and has been uninvited by conferences. We don’t need that type of toxicity in the industry.

    • asyncrosaurus@programming.dev
      link
      fedilink
      arrow-up
      33
      arrow-down
      2
      ·
      5 months ago

      It’s a beginners book filled with a mix of bad and good advice, which takes considerable experience to separate the two. Those who can point out all the bad advice already don’t need the book, and newer developers will pick up absolutely atrocious coding advice. There’s simply better books that target beginners better, like The Pragmatic Programmer.

      So when you are on-boarding junior devs that have bought into the clean code/SOLID dogma, you’re spending several months beating all their terrible coding habits out of them.

      • bleistift2@sopuli.xyz
        link
        fedilink
        English
        arrow-up
        5
        ·
        5 months ago

        While we’re giving advice on good reads, I foudn “Code Complete” to be much more useful than “The Pragmatic Programmer” (also about 10x the size).

    • Carighan Maconar@lemmy.world
      link
      fedilink
      arrow-up
      24
      arrow-down
      1
      ·
      5 months ago

      Personally I have been around longer than him but I used to like his stuff at first.

      As I’ve coded more and more on stuff that is built not only on legacy code but specifically legacy code by coders influenced substantially by clean code… damn has this single author given me a headache like nothing else ever has.

      The level of inane unmaintainability and complexity achieved by younger coders being encouraged or forced to code “clean” is remarkable.

      • anti-idpol action@programming.dev
        link
        fedilink
        arrow-up
        7
        ·
        5 months ago

        personally I’d sum it up this way: it is usually enough to abstract two parts of your code: the repetitive stuff and the stuff that can be separated from external dependencies like db or network. That should be enough to ensure readability and that you can test it properly and not have to deal with rewriting half your codebase when you decide to change an external dependency.

      • Prunebutt@slrpnk.net
        link
        fedilink
        arrow-up
        5
        ·
        5 months ago

        Can you give examples? I genuinely can’t think of how the principles applied with proper restraint not to overdo it make code hard to maintain. But I’ve only watched his talk a few years ago - not the book.

    • noproblemmy@programming.dev
      link
      fedilink
      arrow-up
      7
      arrow-down
      1
      ·
      5 months ago

      I take it as people just joking. Personally I’m in doubt if the tweet is serious and the new book is true, or is it just a joke about refactoring/re-writing code.

  • iAvicenna@lemmy.world
    link
    fedilink
    arrow-up
    25
    arrow-down
    1
    ·
    edit-2
    5 months ago

    if your function has more than four inputs, remember that uncle bob knows where you live

  • Irrational_exuberance@lemmy.world
    link
    fedilink
    arrow-up
    12
    ·
    edit-2
    5 months ago

    Well engineered and ‘clean code’ are two different things. You will know when you look at it.

    A well engineered codebase will always be modularized with time (-10 years)