• aport@programming.dev
    link
    fedilink
    arrow-up
    26
    arrow-down
    2
    ·
    5 months ago

    GitLab still doesn’t even support leaving comments on a commit message. Like, what? GitLab and GitHub have all these fancy shiny features but still suck at offering basic code review functionality.

    I never understood the appeal.

    • allywilson@lemmy.ml
      link
      fedilink
      arrow-up
      21
      arrow-down
      2
      ·
      5 months ago

      I mean, I get it, but that’s also not a thing of git, right? Just because GitHub does something doesn’t mean every other hosting provider needs to. If your code review process is to comment upon specific commits, maybe it’s the code review process that’s wrong?

      • aport@programming.dev
        link
        fedilink
        arrow-up
        3
        ·
        5 months ago

        GitHub doesn’t let you comment on the commit message either. The only one I’ve seen do this properly this is Gerrit. And of course regular old mailing list reviews.

        There are so many blogs and posts about writing good commit messages, using Conventional Commits, etc, and the two most popular forges don’t even let you comment in-line on the commit message during a review.