• 38 Posts
  • 331 Comments
Joined 3 years ago
cake
Cake day: June 23rd, 2023

help-circle
  • The amount of ink that comes with an inkjet printer is tiny. So a new printer comes with 10mL of ink, and the refills are 35mL or more. You quite literally get what you pay for.

    The other reason is that inkjet printers need to be used on a regular basis, or the ink can dry out. But manufacturers have handled this by having the printer drip out tiny bits of ink all the time, so it’s literally using the ink even when you aren’t using it.

    For the vast majority of people, a cheap laser printer is the far better option. Unless you want to produce art prints, but at that point you’re looking at spending a ton of money anyways.











  • Ew no.

    Abusing language features like this (boolean expression short circuit) just makes it harder for other people to come and maintain your code.

    The function does have opportunity for improvement by checking one thing at a time. This flattens the ifs and changes them into proper sentry clauses. It also opens the door to encapsulating their logic and refactoring this function into a proper validator that can return all the reasons a user is invalid.

    Good code is not “elegant” code. It’s code that is simple and unsurprising and can be easily understood by a hungover fresh graduate new hire.










  • I have either written or gotten a variant of every single one of these comments 🫠:

    Please include the JIRA task in the commit title.

    Did you run any manual testing?

    Where’s the PRD link in the commit message?

    Can you please split this into multiple smaller commits?

    Can you combine these two commits?

    Did you email Jon about this because he’s working on that project with Sarah and you might be duplicating efforts.

    This should be named BarFoo instead of FooBar.

    Why aren’t you using CorporateInternalLib16 that does 90% of this?

    Why aren’t you using ThirdPartyPaidLibByExEmployee?

    Why aren’t you using StandardLib thing you forgot existed?

    All our I/O should be async.

    All our hot loop code needs to be sync.

    This will increase latency of NonCoreBusinessFlow by 0.01%. can you shave some time off so we can push in feature B also?

    Please add a feature flag so we can do gradual rollout.

    What operational levers does this have?

    Lgtm - just address those comments