Links:
- https://atproto.com - https://atproto.com/articles/atproto-for-distsys-engineers
- https://www.blackskyweb.xyz - https://bsky.app/profile/rudyfraser.com/post/3l6d7mmzhik2r
For a lot of us, atproto projects are some of the biggest (most users, most publicized, most code written, etc.) projects we’ve ever done. For me, it’s also my first time working in open source (ironically, someone asked me to be more open about that)
If you can help, pls check out open issues.
I know not everyone thinks highly of atproto around these parts, but please don’t let that get in the way of welcoming a fellow rustacean into the open source world 🦀
+++
OK
ATH
NO CARRIER
OK
Sharing for anyone else not familiar with AT Protocol:
The AT Protocol is an open, decentralized network for building social applications.
Account portability and Scalability through activity aggregation
Bluesky uses AT Protocol. The connected network/platform is called the Atmosphere.
Bluesky Social has pledged to transfer the protocol’s development to a standards body. - Wikipedia
I didn’t see any mention of other software/platforms using AT protocol on the protocol website or Wikipedia.
The connected network/platform is called the Atmosphere.
Not sure that is a good name from a search or brand recognition perspective.
Yeah, I thought the same. Pretty bad name.
Some shallow observations without really getting into the code:
misc
- Was hosting
labeler/ResNet50_nsfw_model.pth
in the repository really necessary?
(I like my--filter=tree:0
clones to be maximally fast and small.) - Why not declare all dependencies in the workspace?
- How old is the code (for real)?
rsky-crypto
anyhow
in library code.- Not liking that
multibase
dependency much either. I know thatbase64
at least got re-written since that crate’s last update (Nov 6, 2020).
rsky-feedgen
serde_cbor
is long dead (I was a user myself).- I’m not even sure why
serde_cbor
andserde_ipld_dagcbor
are dependencies anyway. - We moved from
lazy_static
toonce_cell
a long time ago. And your use is available in std on stable Rust today.
rsky-firehose
- Here, all three CBOR dependencies are actually used.
- CBOR (the format) used in
$CURRENT_YEAR
is meh anyway. But I guess that comes from IPLD.
rsky-identity
anyhow
in library code.
rsky-pds
- That’s quite the dependency list! Too long for me to take a closer look.
- How many
*base*
dependencies does one need? All of them of course!
rsky-syntax
lazy_static
andanyhow
again.
That’s all from a code organization and ecosystem PoV. Otherwise, things look normal and not fancy (which is good).
Unfortunately, I don’t have the time to look beyond that at this moment.
Appreciate the review! I’ve forwarded it to the dev :)
- Was hosting