Linus Torvalds expressed frustration over the use of passive voice in merge commit messages, preferring active and imperative language instead.

He provided an example of how commit messages should be rewritten for clarity and consistency across the project.

Torvalds noted that while it’s not a major issue, it does add extra work when he has to rewrite messages to match his preference.

  • MyNameIsRichard@lemmy.ml
    link
    fedilink
    arrow-up
    6
    arrow-down
    5
    ·
    2 months ago

    That’s not scary. The trick when dealing with that kind of review is to parse out the technical and not take the rest personally, which maybe takes a certain kind of personality.

    • hector@sh.itjust.works
      link
      fedilink
      arrow-up
      5
      ·
      2 months ago

      Not being a jerk and having empathy are two necessary things to create a healthy work environment and are especially required when volunteers take from their off-time to work on your project.

    • derpgon@programming.dev
      link
      fedilink
      arrow-up
      2
      ·
      2 months ago

      I do that by default. I have to actively think about empathy when I do CRs, because the other devs (who should not be doing these kinds of mistakes) just can’t fucking do their job right for once.

      But when I am getting a review, I don’t get mad unless I am personally attacked (happened with a colleague who had a very high ego and somehow made it to a higher position, finally being let go about half a year back).