Fixes a minor bug with showing scores for legacy servers.

  • carzian@lemmy.ml
    link
    fedilink
    arrow-up
    3
    ·
    7 months ago

    I can open a bug report, but list view is still not showing the vote scores unfortunately

      • carzian@lemmy.ml
        link
        fedilink
        arrow-up
        4
        ·
        7 months ago

        Ah that fixed it thanks! Should probably be under look and feel? Is it on by default? I don’t remember turning it off

        • MV [Jerboa dev]@lemmy.one
          link
          fedilink
          arrow-up
          5
          ·
          7 months ago

          In Lemmy 0.19.4, scores were reworked. So that you could individually pick which score you like to see (upvote, downvote, total, ratio)

          Before this this option its behaviour was to disable every score type. Now it just hides the “total”. With Lemmy 0.19.4 they did a poll to see which scores are the most popular and should be the default. Upvotes + Downvotes won. So show_scores is now by default false.

          Currently our setting division (‘Account settings’ vs ‘look and feel’) doesn’t make much sense. But ‘look and feel’ is all the settings that are stored on the device. Thus apply to all accounts. Account settings are settings we retrieve from Lemmy and are different per account.

          So that brings us to the listingviewmode. That shows the total_scores but since its disabled, it is hidden. I’ll probably rework it so that it shows the upvotes if ‘shows_scores’ is disabled.