calling map(obj.func) will pass func but won’t set the this parameter correctly. If the called method uses this you will have a bad time.
The code you actually want would be retval.map(v => self.cleanupMetadata(v)) or the old-skool retval.map(self.cleanupMetadata.bind(self)).
Also the first version reuses the Array which may be important, but even if not will likely result in better performance. (Although this is likely mitigated by making the array polymorphic depending on the return type of cleanupMetadata and the overhead of forEach vs map.)
Trivially, could also just be a
retVal.map(self.cleanupMetadata)But it can’t! (Maybe)
calling
map(obj.func)will passfuncbut won’t set thethisparameter correctly. If the called method usesthisyou will have a bad time.The code you actually want would be
retval.map(v => self.cleanupMetadata(v))or the old-skoolretval.map(self.cleanupMetadata.bind(self)).Also the first version reuses the Array which may be important, but even if not will likely result in better performance. (Although this is likely mitigated by making the array polymorphic depending on the return type of
cleanupMetadataand the overhead offorEachvsmap.)Wow, isn’t JS a great language.